[Image_tag] Update to remove lazy loading and let it automatically decide the best loading strategy

[ludoboludo]

PR Summary:

There has been some recent changes to the image_tag filter and it will now by default pick the best loading option for you.
We've used loading="lazy" in a lot of places in our code because such a feature did not exist at the time and we weren't able to know whether a section was coming up first or not.
This PR is to remove the use of lazy loading so that it can be automatically applied where needed. It will better the overall performance of the theme.
Here is an article explaining the new feature: https://performance.shopify.com/blogs/blog/announcing-new-liquid-features-for-better-web-performance

Why are these changes introduced?

Better performance

What approach did you take?

Removed lazy loading in most sections. Only for the slideshow section I added an if statement to only lazy load images that aren't the first slide.

Other considerations

There could be extra logic to add a fetch priority when the section is the first one. Something like:

{% liquid
  assign fetchPriority = "auto"
  if section.location == "template" and section.index < 3
    assign fetchPriority = "high"
  endif
%}

Decision log

#	Decision	Alternatives	Rationale	Downsides
1

Visual impact on existing themes

Should not visually impact themes. It should load above the fold images faster.

Testing steps/scenarios

• Test all the section edited in the PR. Add an image in the editor,
• Re order the section and make sure no lazy loading is applied when the section is one of the first 3 and the rest does get lazy loading.

Demo links

• Store
• Editor

Checklist

• Added PR summary for release notes
• Requested review from UX (Only for changes that are affecting the experience or perceivable visual details)
• Created a ticket for the help.shopify.com documentation team about updates to theme settings. (Internal-only task)
• Followed theme code principles
• Linted with Theme Check
• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility

[krzksz]

LGTM! 👍

Personally, I'm ok with us shipping this and fetchpriority in separate releases or at least in a separate PR. I feel there has to be some additional discussion on where we can apply this attribute safely.

[eugenekasimov]

🚀