Skip to content

address review comments #9769

address review comments

address review comments #9769

GitHub Actions / Theme Check Report succeeded Jul 25, 2024 in 3s

Theme Check Report

0 error(s), 35 warning(s) found

Details

Configuration

Actions Input

Name Value
theme_root .
flags (not provided)
version (not provided)

ThemeCheck Configuration

---
root: "."
require: []
include_categories: []
exclude_categories: []
ignore:
- node_modules/*
extends: :nothing
ConvertIncludeToRender:
  enabled: true
  ignore: []
LiquidTag:
  enabled: true
  ignore: []
  min_consecutive_statements: 5
MissingTemplate:
  enabled: true
  ignore: []
  ignore_missing: []
NestedSnippet:
  enabled: true
  ignore: []
  max_nesting_level: 3
RequiredLayoutThemeObject:
  enabled: true
  ignore: []
SpaceInsideBraces:
  enabled: true
  ignore: []
SyntaxError:
  enabled: true
  ignore: []
TemplateLength:
  enabled: false
  ignore: []
  max_length: 600
  exclude_schema: true
  exclude_stylesheet: true
  exclude_javascript: true
UnknownFilter:
  enabled: true
  ignore: []
UnusedAssign:
  enabled: true
  ignore: []
UnusedSnippet:
  enabled: true
  ignore: []
MatchingSchemaTranslations:
  enabled: true
  ignore: []
MatchingTranslations:
  enabled: false
  ignore: []
DefaultLocale:
  enabled: true
  ignore: []
TranslationKeyExists:
  enabled: true
  ignore: []
ValidHTMLTranslation:
  enabled: true
  ignore: []
ValidJson:
  enabled: true
  ignore: []
ValidSchema:
  enabled: true
  ignore: []
MissingRequiredTemplateFiles:
  enabled: true
  ignore: []
UndefinedObject:
  enabled: true
  ignore: []
  exclude_snippets: true
  config_type: :default
RequiredDirectories:
  enabled: true
  ignore: []
DeprecatedFilter:
  enabled: true
  ignore: []
DeprecateLazysizes:
  enabled: true
  ignore: []
DeprecateBgsizes:
  enabled: true
  ignore: []
MissingEnableComment:
  enabled: true
  ignore: []
ParserBlockingJavaScript:
  enabled: true
  ignore: []
ParserBlockingScriptTag:
  enabled: true
  ignore: []
AssetPreload:
  enabled: true
  ignore: []
AssetSizeJavaScript:
  enabled: false
  threshold_in_bytes: 10000
  ignore: []
AssetSizeCSS:
  enabled: false
  threshold_in_bytes: 100000
  ignore: []
AssetSizeCSSStylesheetTag:
  enabled: false
  threshold_in_bytes: 100000
  ignore: []
ImgWidthAndHeight:
  enabled: true
  ignore: []
RemoteAsset:
  enabled: true
  ignore: []
AssetUrlFilters:
  enabled: true
  ignore: []
ContentForHeaderModification:
  enabled: true
  ignore: []
ImgLazyLoading:
  enabled: true
  ignore: []
HtmlParsingError:
  enabled: true
  ignore: []
AssetSizeAppBlockJavaScript:
  enabled: false
  ignore: []
  threshold_in_bytes: 10000
AssetSizeAppBlockCSS:
  enabled: false
  ignore: []
  threshold_in_bytes: 100000
AppBlockValidTags:
  enabled: false
  ignore: []
PaginationSize:
  enabled: true
  ignore: []
  min_size: 1
  max_size: 50
DeprecatedGlobalAppBlockType:
  enabled: true
SchemaJsonFormat:
  enabled: true
  start_level: 0
  indent: "  "

Annotations

Check warning on line 179 in layout/password.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/password.liquid#L179

[AssetPreload] For better performance, prefer using the preload_tag filter

Check warning on line 184 in layout/password.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/password.liquid#L184

[AssetPreload] For better performance, prefer using the preload_tag filter

Check warning on line 271 in layout/theme.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/theme.liquid#L271

[AssetPreload] For better performance, prefer using the preload_tag filter

Check warning on line 276 in layout/theme.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/theme.liquid#L276

[AssetPreload] For better performance, prefer using the preload_tag filter

Check notice on line 163 in sections/announcement-bar.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/announcement-bar.liquid#L163

[SchemaJsonFormat] JSON formatting could be improved

Check warning on line 5 in sections/bulk-quick-order-list.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/bulk-quick-order-list.liquid#L5

[NestedSnippet] Too many nested snippets

Check warning on line 5 in sections/bulk-quick-order-list.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/bulk-quick-order-list.liquid#L5

[NestedSnippet] Too many nested snippets

Check warning on line 5 in sections/bulk-quick-order-list.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/bulk-quick-order-list.liquid#L5

[NestedSnippet] Too many nested snippets

Check warning on line 5 in sections/bulk-quick-order-list.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/bulk-quick-order-list.liquid#L5

[NestedSnippet] Too many nested snippets

Check warning on line 5 in sections/bulk-quick-order-list.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/bulk-quick-order-list.liquid#L5

[NestedSnippet] Too many nested snippets

Check warning on line 5 in sections/bulk-quick-order-list.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/bulk-quick-order-list.liquid#L5

[NestedSnippet] Too many nested snippets

Check notice on line 7 in sections/bulk-quick-order-list.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/bulk-quick-order-list.liquid#L7

[SchemaJsonFormat] JSON formatting could be improved

Check warning on line 95 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L95

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check notice on line 214 in sections/collage.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collage.liquid#L214

[SchemaJsonFormat] JSON formatting could be improved

Check notice on line 109 in sections/collapsible-content.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collapsible-content.liquid#L109

[SchemaJsonFormat] JSON formatting could be improved

Check notice on line 132 in sections/collection-list.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/collection-list.liquid#L132

[SchemaJsonFormat] JSON formatting could be improved

Check notice on line 136 in sections/contact-form.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/contact-form.liquid#L136

[SchemaJsonFormat] JSON formatting could be improved

Check notice on line 139 in sections/email-signup-banner.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/email-signup-banner.liquid#L139

[SchemaJsonFormat] JSON formatting could be improved

Check notice on line 189 in sections/featured-blog.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/featured-blog.liquid#L189

[SchemaJsonFormat] JSON formatting could be improved

Check notice on line 196 in sections/featured-collection.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/featured-collection.liquid#L196

[SchemaJsonFormat] JSON formatting could be improved

Check warning on line 383 in sections/featured-product.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/featured-product.liquid#L379-L383

[NestedSnippet] Too many nested snippets

Check warning on line 383 in sections/featured-product.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/featured-product.liquid#L379-L383

[NestedSnippet] Too many nested snippets

Check warning on line 383 in sections/featured-product.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/featured-product.liquid#L379-L383

[NestedSnippet] Too many nested snippets

Check warning on line 472 in sections/featured-product.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/featured-product.liquid#L472

[UnusedAssign] `seo_media` is never used

Check notice on line 486 in sections/featured-product.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/featured-product.liquid#L486

[SchemaJsonFormat] JSON formatting could be improved