Update to Node 10 + dependencies #221
Conversation
beefchimi
added
examples
| @@ -61,9 +61,6 @@ export default function DragEvents() { | |||
| }); | |||
|
|
|||
| draggable.on('drag:move', (evt) => { | |||
| // Required to help restrict the draggable element to the container | |||
| evt.cancel(); | |||
There was a problem hiding this comment.
@tsov I don't know how this was working for so long... but drag:move is not cancellable... thing is, at one point this worked and it prevented the "Pill Switch" from being pulled outside of the "Track".
Is there a similar trick I can use here?
There was a problem hiding this comment.
Hmm, I will check this branch out later and see what's up, drag:move should be a cancelable event https://github.com/Shopify/draggable/blob/master/src/Draggable/Draggable.js#L492
| height: rows(6); | ||
| // suddenly breaking in Chrome... | ||
| // subtrack a single pixel to fix the issue | ||
| height: rows(6) - 0.1rem; |
There was a problem hiding this comment.
Layout broke... I don't know why. This was the fix.
| @@ -61,9 +61,6 @@ export default function DragEvents() { | |||
| }); | |||
|
|
|||
| draggable.on('drag:move', (evt) => { | |||
| // Required to help restrict the draggable element to the container | |||
| evt.cancel(); | |||
There was a problem hiding this comment.
Hmm, I will check this branch out later and see what's up, drag:move should be a cancelable event https://github.com/Shopify/draggable/blob/master/src/Draggable/Draggable.js#L492
Yea I thought so as well, as clearly at one point it was, but when it stopped working in this latest update, I went and looked at the README and it says "cancelable: false" https://github.com/Shopify/draggable/tree/master/src/Draggable/DragEvent#dragmoveevent That is really the only issue I'd want you to look into. The rest I can take care of, and if not, I'll reduce the scope of this PR. Might not get around to it until after vacation. |
beefchimi
changed the title
Solves:
Browsers: