Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Update eslint-plugin-react and enforce usage of <> for fragments #223

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Feb 21, 2019

@GoodForOneFare
Copy link
Member

Looks 7.12 added a bunch of new rules. Can we at least raise an issue to figure out our defaults for these?

Ideally, this PR would add them all, though :)

@BPScott
Copy link
Member Author

BPScott commented Feb 21, 2019

Looks 7.12 added a bunch of new rules. Can we at least raise an issue to figure out our defaults for these?

jsx-fragments is the only new rule. The rest of the Added section is adding new functionality to existing rules rather than adding entirely new rules. lib/config/rules/react.js already contains defaults for no-typos, jsx-indent and jsx-no-literals, the same goes for every rule mentioned in the fixed block.

@BPScott BPScott merged commit b40b72d into master Feb 21, 2019
@BPScott BPScott deleted the react-fragments branch February 21, 2019 21:05
@GoodForOneFare
Copy link
Member

Cool, so long as someone vetted those changes 🚢

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants