Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Fix duplicate camelcase rule #238

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Fix duplicate camelcase rule #238

merged 1 commit into from
Apr 9, 2019

Conversation

cartogram
Copy link
Contributor

@cartogram cartogram commented Apr 9, 2019

Currently, we are getting duplicate reports for camelcase variables.

To solve this in this PR I am keeping the babel/camelcase rule on unless they are using the typescript config, at which point we can use the @typescript-eslint/camelcase rule and turn off the babel rule.

Screen Shot 2019-04-09 at 10 08 30 AM

Copy link
Member

@GoodForOneFare GoodForOneFare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense. It'd be nice if this was covered by tests/lib/config/typescript.js, but setting up a test is probably more effort than it's worth.

CHANGELOG and 🚢 👍

@cartogram cartogram merged commit ea15244 into master Apr 9, 2019
@cartogram cartogram deleted the dup-camelcase branch April 9, 2019 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants