Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Add trailing comma function support to comma-dangle and prettier config #55

Merged
merged 6 commits into from
Dec 1, 2017

Conversation

ismail-syed
Copy link
Contributor

  • comma-dangle will now enforce trailing commas in multi-line function calls via the esnext config. This was previously enforced through our babel config (babel/func-params-comma-dangle) but the rule has been deprecated. We never updated the eslint comma-dangle to reflect the deprecation.

  • the trailingComma setting in our prettier config has also been updated the trailingComma option to all. This will also enforce trailing commas in multiline function calls

  • Added a .prettierrc file to the project so maintainers can get prettier formatting via editor plugins

@ismail-syed ismail-syed force-pushed the comma-dangle-function branch 4 times, most recently from 8fa8d32 to ba7073b Compare December 1, 2017 16:01
@ismail-syed
Copy link
Contributor Author

ismail-syed commented Dec 1, 2017

@lemonmade, any ideas why CI is failing?
Everything is fine locally, I tried rebuilding without cache too.

Update: had to bump node in CI.

@ismail-syed ismail-syed merged commit 615c2b1 into master Dec 1, 2017
@ismail-syed ismail-syed deleted the comma-dangle-function branch December 1, 2017 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant