Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update APIs to 2024-10 #562

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Update APIs to 2024-10 #562

merged 3 commits into from
Oct 23, 2024

Conversation

davejcameron
Copy link
Contributor

Ran the update utility to bump all of the APIs to 2024-10

andrewhassan
andrewhassan reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@andrewhassan andrewhassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me 👍 It looks like one of the Rust functions broke though.

@davejcameron davejcameron marked this pull request as ready for review October 23, 2024 14:33
andrewhassan
andrewhassan approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@andrewhassan andrewhassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't 🎩, but code LGTM! I also searched for 2024-07 and found no other instances.

mssalemi
mssalemi approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@mssalemi mssalemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Top hatted dev / deploy with a couple of the functions and worked as expected.

@davejcameron davejcameron merged commit 5731133 into main Oct 23, 2024
4 checks passed
@davejcameron davejcameron deleted the 2024-10 branch October 23, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalemi mssalemi mssalemi approved these changes

@andrewhassan andrewhassan andrewhassan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davejcameron @andrewhassan @mssalemi