Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize Ruby Version to .ruby-version #36

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Centralize Ruby Version to .ruby-version #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
478c1f0
Set .ruby-version to 2.7.8
jenshenny Apr 2, 2024
aefc266
Remove ruby reference in Gemfile
jenshenny Apr 2, 2024
61c9405
Remove ruby version definition in CI/CD
jenshenny Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ jobs:
- uses: actions/checkout@v3

- uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6

- name: Install dependencies
run: bundle install
Expand Down
1 change: 1 addition & 0 deletions .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2.6.10
2 changes: 0 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# frozen_string_literal: true
source "https://rubygems.org"

ruby ">= 2.6"

# None of these can actually be used in a development copy of dev
# They are all for CI and tests
# `dev` uses no gems
Expand Down
3 changes: 0 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,5 @@ DEPENDENCIES
rubocop-rake
rubocop-shopify (~> 2.0.1)

RUBY VERSION
ruby 2.7.2p137

BUNDLED WITH
2.2.22
2 changes: 1 addition & 1 deletion dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ type:
- ruby

up:
- ruby: "2.6.10"
- ruby
- bundler

test: "rake test"
Expand Down
Loading