include xstate in builds (#64)

* include xstate in builds * Fix NextJS issues by including files with sideeffects See vitejs/vite#10866 for more details
Shopify · Nov 11, 2022 · 3add3be · 3add3be
1 parent f1cb723
commit 3add3be
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -54,7 +54,12 @@
   "types": "./dist/types/index.d.ts",
   "unpkg": "./dist/umd/hydrogen-react.prod.js",
   "jsdelivr": "./dist/umd/hydrogen-react.prod.js",
-  "sideEffects": false,
+  "sideEffects": [
+    "dist/dev/node_modules/use-sync-external-store/shim/with-selector.mjs",
+    "dist/prod/node_modules/use-sync-external-store/shim/with-selector.mjs",
+    "dist/dev/node_modules/use-sync-external-store/shim/with-selector.js",
+    "dist/prod/node_modules/use-sync-external-store/shim/with-selector.js"
+  ],
   "scripts": {
     "clean-dist": "rimraf ./dist",
     "dev": "run-s clean-dist dev:demo",

diff --git a/packages/react/vite.config.ts b/packages/react/vite.config.ts
@@ -57,17 +57,16 @@ export default defineConfig(({mode}) => {
       minify: false,
       emptyOutDir: false,
       rollupOptions: {
-        // don't bundle these packages into our lib
-        external: (id, parentId) => {
+        external: (id) => {
           /**
            * Don't bundle these packages into our lib
            *
            * This creates a better build for node esm environments,
            * but if we wanted a browser esm build, we would either have to tell devs to use "import maps"
            * or to create a new bundle that doesn't use these as externals
            * */
-          if (parentId?.includes('@xstate') || id.includes('@xstate')) {
-            return true;
+          if (id.includes('xstate')) {
+            return false;
           }
 
           return externals.includes(id);