This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Update Money component to use individual props #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Due to this change, the following components have had their props changed: | ||
|
|
||
| - `<Money data={moneyV2}/>` is now `<Money amount={moneyV2.amount} currencyCode={moneyV2.currencyCode}/>` |
There was a problem hiding this comment.
V2 was removed recently (I believe in 2022-10), right? Will we be updating this library to reflect that?
There was a problem hiding this comment.
PriceV2 has been deprecated (but still exists).
MoneyV2 hasn't had that happen to it yet, as far as the GraphQL signature goes.
There was a problem hiding this comment.
Example: subtotalPrice and subtotalPriceV2 both still use MoneyV2
|
Holding off on this for now. I'll just close the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the changelog for more information.