Fix an issue where cache fails to match on Oxygen/Cloudflare #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL requires to be URRIEncoded to properly match
blittle
commented
Jul 19, 2023
.changeset/smooth-dryers-march.md
Outdated
| '@shopify/hydrogen': patch | ||
| --- | ||
|
|
||
| Fix an issue where cache failed to match requests |
There was a problem hiding this comment.
@wizardlyhel I see in the H2 fix, we also directly use the URL when removing from the cache. Is that necessary?
There was a problem hiding this comment.
no - I miss that. That should be just request
|
This needs update too https://github.com/Shopify/hydrogen-v1/blob/v1.x-2022-07/packages/hydrogen/src/foundation/Cache/cache.ts#L105-L117 make sure to set the padded cache control on |
wizardlyhel
approved these changes
Jul 19, 2023
jgodson
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL requires to be URI encoded to properly match
Description
Additional context
Before submitting the PR, please make sure you do the following:
fixes #123)yarn changeset addif this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning