Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for sourcemap warnings #277

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

frandiox
Copy link
Contributor

Description

Closes #140

The sourcemaps fix in Vite is not enough for us because that id parameter contains the querystring ?no-proxy, and it breaks the sourcemap.

This PR implements a workaround on our side until it is fixed in Vite (I'll open PRs there soon).

Apart from that, looks like react-ssr-prepass soucemap is broken so this also ignores it. I tried to read the proper sourcemap from a file next to the source code, but looks like it crashes in Jest and build... that's why Vite is ignoring it, probably.


Before submitting the PR, please make sure you do the following:

  • Add your change under the Unreleased heading in the package's CHANGELOG.md
  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository for your change, if needed

@frandiox
Copy link
Contributor Author

PR in Vite here: vitejs/vite#5760
Not sure if it will be approved, though, perhaps breaks something else.

@jplhomer jplhomer merged commit 13e628e into main Nov 19, 2021
@jplhomer jplhomer deleted the fd-sourcemap-warnings branch November 19, 2021 14:19
rafaelstz pushed a commit to rafaelstz/hydrogen that referenced this pull request Mar 4, 2023
Be sure to `prepack` build the dist packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RSC client components displaying warning in Vite dev console
2 participants