This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
[Feature]Add missing associated user data to the session #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Thank you for making this change! Code-wise I see it's the same change as before so I will approve it.
@TheMallen, could I trouble you for your thoughts, as requested by @tanema in the original PR?
simonhaenisch
added a commit
to simonhaenisch/koa-shopify-auth
that referenced
this pull request
Nov 5, 2020
|
Hi guys, could one of you confirm this is not out yet? Currently can't find user information on my session. |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I wanted to get associatedUserId after user authentification using koa-shopiy-auth, but I could not find it in the session.
A lot of Shopify App beginner-developers (including me) use this approach for user authentification, because Shopify introduces that way in the tutorial.
Also, this is same as this PR Shopify/quilt#1542 .
WHAT is this pull request doing?
Add associated user data and scope to the session.
This is particularly useful for determining the currently authenticated user in online access mode.
See also: Authenticate With OAuth Docs
Type of change
Checklist