-
Notifications
You must be signed in to change notification settings - Fork 63
➖ Remove the need for external safe compare #26
➖ Remove the need for external safe compare #26
Conversation
Thanks for catching my goofs @mkevinosullivan! 🙏 |
👋 Hi Anthony, I was just about to merge in the changes and create a release until I noticed there are no unit tests for the When you get a chance, can you create |
@mkevinosullivan I added a test but had a question. Although TypeScript is being used, |
It's generally a good idea, but I think it's OK given the limited usage here. Thank you for the contribution! |
Description
Fixes #2
The
safe-compare
was an unneeded external dependency. This PR removes it and adds a file to do it without new deps.To test locally I built a new Shopify App and started a local dev server. I was able to install the app on my test store.
Type of change
Checklist