Fix inconsistency in authentication path prefix to remove trailing slash

[devjones]

WHY are these changes introduced?

There are inconsistent assumptions around whether the authentication middleware should use a trailing slash in the prefix. The createShopifyAuth function assumes no trailing slash, but requestStorageAccess assumes trailing slash. This leads to a 404 error when requestStorageAccess attempts to access a url in the form: customprefixauth/inline?shop=. Note the missing slash between customprefix and auth/.

WHAT is this pull request doing?

Update the requestStorageAccess function to assume no trailing slash in the prefix.

Type of change

• Patch: Bug (non-breaking change which fixes an issue)
• Minor: New feature (non-breaking change which adds functionality)
• Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• I have added a changelog entry, prefixed by the type of change noted above
• I have added/updated tests for this change

[raffi1300]

The prefix is broken on the master branch - can confirm.

Trying out your fixes in my forked repo and it solves the prefix issue. Hopefully the official package can be updated.

Thanks!

[tanema]

Thanks for the contribution!

[nmalzieu]

Hi @tanema do you know when this will be released? When is the next release? Thx!

[yoadsn]

@tanema Asking again - when do you expect this to be released? This breaks the Auth flow.
Thanks.

[yoadsn]

So... until we get this fix - if you use Express (for example) just do:

// Working around an existing bug
// https://github.com/Shopify/koa-shopify-auth/issues/13
const BUG_SHOPIFY_ROOT_PATH = '/shopifyauth';
const BUG_PATCHED_SHOPIFY_ROOT_PATH = '/shopify/auth';

    if (req.path.startsWith(BUG_SHOPIFY_ROOT_PATH)) {
      res.redirect(
        req.url.replace(BUG_SHOPIFY_ROOT_PATH, BUG_PATCHED_SHOPIFY_ROOT_PATH)
      );
    }

🙄