Merge pull request #1773 from Shopify/liquid-tag-whitespace-control-w…

…ith-comment don't reset Liquid tag's whitespace control from comment tag
Shopify · Jan 5, 2024 · f5ed540 · f5ed540
2 parents 96a0363 + a3c8376
commit f5ed540
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/lib/liquid/tags/comment.rb b/lib/liquid/tags/comment.rb
@@ -61,11 +61,11 @@ def parse_body(body, tokenizer)
             comment_tag_depth += 1
           when "endcomment"
             comment_tag_depth -= 1
+          end
 
-            if comment_tag_depth.zero?
-              parse_context.trim_whitespace = (token[-3] == WhitespaceControl)
-              return false
-            end
+          if comment_tag_depth.zero?
+            parse_context.trim_whitespace = (token[-3] == WhitespaceControl) unless tokenizer.for_liquid_tag
+            return false
           end
         end
 

diff --git a/test/unit/tags/comment_tag_unit_test.rb b/test/unit/tags/comment_tag_unit_test.rb
@@ -187,4 +187,16 @@ def test_with_whitespace_control
       Hello!
     LIQUID
   end
+
+  def test_dont_override_liquid_tag_whitespace_control
+    assert_template_result("Hello!World!", <<~LIQUID.chomp)
+      Hello!
+      {%- liquid
+        comment
+         this is inside a liquid tag
+        endcomment
+      -%}
+      World!
+    LIQUID
+  end
 end