Reserve keyword arguments for new options in assert_template_result #1612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As mentioned in #1611
However, we can't just add keyword arguments to assert_template_result without calls to it that pass assigns as keyword arguments.
Solution
Update calls to
assert_template_result
that pass assigns as keyword arguments and instead pass a hash explicitly.I also turned the message positional argument to assert_template_result into a keyword argument, which also reserves the ability to add additional keyword arguments without breaking its callers.
I also removed an unused assert_template_result_matches method and removed an unnecessary
assigns
argument toassert_match_syntax_error