Stop using assert_template_result in some tests depending on language extension #1622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1621
As such, I've written a PR as a sample of this sort of change, before make this change more broadly.
The
assert_template_result
test helper is a pretty thin abstraction, so using the library API can actually make the test a bit clearer to those familiar with that API, even though it is a bit more verbose.An alternative would be to move all these tests to different test files, perhaps in a different directory. However, I think it does make sense for these tests to stay in the test/integration/ folder (since they are integration tests for this library) and it seems like these changes would be easier to review than moving tests between files.