Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI (as it installs RuboCop 1.45.1 and fails) #1686

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Feb 13, 2023

The CI no longer uses RuboCop 1.44.1 (instead it uses 1.45.1). So, it's failing with this error now:

Inspecting 136 files
.....................................................................W..................................................................

Offenses:

performance/shopify/database.rb:54:3: W: Lint/Debugger: Remove debugger entry point p(Database.tables['collections']['frontpage'].keys).
  p(Database.tables['collections']['frontpage'].keys)
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

136 files inspected, 1 offense detected

Also, I can open a following PR to remove rubocop from the Gemfile and update rubocop-shopify to `2.12.0' (still, it will require broader changes).

@dylanahsmith
Copy link
Contributor

It makes sense to be more specific with the rubocop version to avoid having CI silently break by inheriting these non-backwards compatible changes. However, I think we could also remove that offending code, since it does seem to be for debugging.

@karreiro
Copy link
Contributor Author

Thank you for the review, @dylanahsmith! I've removed the debugging snippet on this PR and merged it.

Also, following this work, I've opened #1687 updating rubocop-shopify.

@karreiro karreiro deleted the fix-ci-rubocop branch February 15, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants