update variable's context before invoking its to_liquid #1781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to solve?
Liquid-C PR: Shopify/liquid-c#212 (Liquid-C PR needs to be merged first)
On variable lookups,
Context
is invoking the drop'sto_liquid
function, and update the valuescontext
to itself.This becomes problematic if the drop's
to_liquid
has some contextual checks:We could solve issue by updating the
Context#find_variable
to update the drop'scontext
before invoking itsto_liquid
method.