Fallback to binary comparison when contains
RHS is UTF8 encoded
#1783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base64 decoding of strings always results in a
Encoding::BINARY
string result. Unfortunately, this means thecontains
operator will throw anEncoding::CompatibilityError
whenever we attempt to compare the decoded result against a UTF8 string.Today, the result of the above templates is:
But what about this template?
If you don't know off the top of your head, you're in good company. Neither did I.
Obviously, throwing an internal error is not ideal. Instead, let's fallback to binary comparison of the string since that seems to me like the most "unsuprising" thing to do here.