Order statuses in memory, consolidate indexing

[:task_name, :status] is used on the index.
[:task_name, :status, created_at: :desc] is used on the show page.

Co-authored-by: Paulo Barros <[email protected]>

app/models/maintenance_tasks/run.rb

@@ -49,7 +49,7 @@ class Run < ApplicationRecord
     serialize :backtrace
     serialize :arguments, JSON
 
-    scope :active, -> { where(status: ACTIVE_STATUSES).order(status: :asc) }
+    scope :active, -> { where(status: ACTIVE_STATUSES) }
     scope :completed, -> { where(status: COMPLETED_STATUSES) }
 
     # Ensure ActiveStorage is in use before preloading the attachments

app/models/maintenance_tasks/task_data.rb

@@ -62,7 +62,7 @@ def available_tasks
           tasks << TaskData.new(task_name, last_run)
         end
 
-        tasks.sort_by!(&:name)
+        tasks.sort_by! { |task| [task.name, task.status] }
       end
     end
 

db/migrate/20220713131925_add_index_on_task_name_and_status_to_runs.rb

@@ -2,7 +2,12 @@
 
 class AddIndexOnTaskNameAndStatusToRuns < ActiveRecord::Migration[6.0]
   def change
-    add_index(:maintenance_tasks_runs, [:task_name, :status],
-      order: { status: :asc })
+    remove_index(:maintenance_tasks_runs,
+      column: [:task_name, :created_at], order: { created_at: :desc },
+      name: :index_maintenance_tasks_runs_on_task_name_and_created_at)
+
+    add_index(:maintenance_tasks_runs, [:task_name, :status, :created_at],
+      name: :index_maintenance_tasks_runs,
+      order: { created_at: :desc })
   end
 end

test/dummy/db/schema.rb

@@ -11,6 +11,7 @@
 # It's strongly recommended that you check this file into your version control system.
 
 ActiveRecord::Schema.define(version: 2022_07_13_131925) do
+
   create_table "active_storage_attachments", force: :cascade do |t|
     t.string "name", null: false
     t.string "record_type", null: false
@@ -56,8 +57,7 @@
     t.datetime "updated_at", precision: 6, null: false
     t.text "arguments"
     t.integer "lock_version", default: 0, null: false
-    t.index ["task_name", "created_at"], name: "index_maintenance_tasks_runs_on_task_name_and_created_at", order: { created_at: :desc }
-    t.index ["task_name", "status"], name: "index_maintenance_tasks_runs_on_task_name_and_status"
+    t.index ["task_name", "status", "created_at"], name: "index_maintenance_tasks_runs", order: { created_at: :desc }
   end
 
   create_table "posts", force: :cascade do |t|