Attach CSVs to runs #300
Merged
Attach CSVs to runs #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianna-chang-shopify
force-pushed
the
attach-csvs-to-runs
branch
from
bffef80
to
b64b55a
Compare
Merged
etiennebarrie
approved these changes
Jan 18, 2021
adrianna-chang-shopify
force-pushed
the
attach-csvs-to-runs
branch
from
b64b55a
to
3bdd640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smallish PR, as ActiveStorage handles all of the complexity associated with attaching an uploaded file to an ActiveRecord.
This PR attaches a
csv_fileto our Run model using thehas_one_attachedmacro (this will always be a 1:1 relationship).The
Runnerclass is now responsible for attaching an incomingcsv_fileto newly created runs in its#runmethod. It will be up to theTasksController/ CLI to pass the CSV from the UI or command line to the runner.