Allow CSV files for previous runs to be downloaded via the UI #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianna-chang-shopify
force-pushed
the
show-uploaded-csvs-for-csv-tasks
branch
3 times, most recently
from
4bebdd2
to
552d363
Compare
etiennebarrie
approved these changes
Feb 1, 2021
adrianna-chang-shopify
force-pushed
the
show-uploaded-csvs-for-csv-tasks
branch
from
552d363
to
4362559
Compare
adrianna-chang-shopify
force-pushed
the
show-uploaded-csvs-for-csv-tasks
branch
from
4362559
to
d8687d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages Active Storage's download link helper to provide download links for CSV attachments associated with previous runs for CSV Tasks. Note that we have to use
Rails.application.routes.url_helpers.rails_blob_pathinstead ofrails_blob_pathbecause the download URL is associated with the host app, not the engine (and additionally, we don't specify Active Storage as a dependency of the engine, so this helper isn't even available to us).Since we're using
run.csv_file.attached?to check whether to show the download link, I've added preloading for the CSV file attachments when we generate theActiveRecord::Relationfor Runs, as @etiennebarrie suggested. (And we can usewith_attached_csv_file, since this scope ships out-of-the-box with ActiveStorage)To 🎩
http://localhost:3000/maintenance_tasks/tasks/Maintenance::ImportPostsTask/sample.csvfromtest/fixtures/filesDownload CSVlink that appears when the Task finishes