Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cursor from bigint to string #339

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Change cursor from bigint to string #339

merged 1 commit into from
Jul 5, 2023

Commits on Jun 26, 2023

  1. Change cursor from bigint to string 

    Working on the upcoming support for tasks backed by custom enumerators
surfaced the need for non-numeric cursors.

For instance, one might have a task that iterates over resources backed
by some API providing its own opaque string cursor, which would be
impossible to serialize to a bigint column.

As such, this changes the maintenance_tasks_runs.cursor column to be a
string. For this to work, we must deserialize the cursor back to an
integer in the Array and CSV collection cases, while the ActiveRecord
case is handled transparently.

Co-authored-by: Adrianna Chang <[email protected]>
Co-authored-by: Sam Bostock <[email protected]>
    @sambostock @adrianna-chang-shopify @etiennebarrie
    2 people authored and etiennebarrie committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    75babc5 View commit details
    Browse the repository at this point in the history