Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update templates to prefer double-quoted strings #606

Merged
1 commit merged into from
Apr 6, 2022
Merged

update templates to prefer double-quoted strings #606

1 commit merged into from
Apr 6, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2022

While Rubocop always autocorrects it after the tests are generated:

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping

I figured I'd update the templates to match our style guide and prefer double-quoted strings, and save Rubocop some work

adrianna-chang-shopify
adrianna-chang-shopify approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@adrianna-chang-shopify adrianna-chang-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@ghost ghost merged commit dbbc26b into main Apr 6, 2022
@ghost ghost deleted the perfer-double-quoted-strings-templates branch April 6, 2022 19:16
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems May 6, 2022 20:12 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems-v1 May 9, 2022 12:49 Inactive
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianna-chang-shopify @mmenanno