Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS updates #607

Merged
merged 3 commits into from
Apr 7, 2022
Merged

CSS updates #607

merged 3 commits into from
Apr 7, 2022

Conversation

etiennebarrie
Copy link
Member

No description provided.

To compute the digest:

$ curl https://cdn.jsdelivr.net/npm/[email protected]/css/bulma.css -s | openssl dgst -sha384 -binary | openssl base64 -A
The content for the digest is everything in the style tag, strictly
after the ">" and before the "<", so it starts with a line feed ("\n")
and ends with the spaces for indentation.
That's just for the dummy app though.
Copy link
Contributor

@adrianna-chang-shopify adrianna-chang-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎩 the digests and they look good.

Out of curiosity, is there a reason we switched to a sha-384 hash algorithm?

@etiennebarrie
Copy link
Member Author

No other reason than that's what was documented at https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity.

@etiennebarrie etiennebarrie merged commit 6508601 into main Apr 7, 2022
@etiennebarrie etiennebarrie deleted the css branch April 7, 2022 13:22
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems May 6, 2022 20:12 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems-v1 May 9, 2022 12:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants