Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use helper for HTML interpolation #628

Merged
merged 3 commits into from
May 9, 2022
Merged

Use helper for HTML interpolation #628

merged 3 commits into from
May 9, 2022

Conversation

etiennebarrie
Copy link
Member

Fixes #627

cc @larouxn

larouxn
larouxn approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@larouxn larouxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not 🎩 but changes looks reasonable to resolve the issue. Thanks for the quick fix and release!

@etiennebarrie
Copy link
Member Author

I've also added better_html to the Gemfile so that we ensure compatibility with it. (Doing so on main fails as expected.)

@etiennebarrie
Use tag helper for the data-refresh attribute
1cd8de7 
Not interpolating directly removes a potential surface for
vulnerabilities, and allows the gem to work with better_html installed
in the bundle.
@etiennebarrie
Bump patch version
aac801e
@etiennebarrie
Add better_html as a dependency
3cdec44
@etiennebarrie
Copy link
Member Author

Rebased on top of an older version of main to be able to have a separate branch for v1.x.

@etiennebarrie etiennebarrie merged commit 98e2b3d into main May 9, 2022
@etiennebarrie etiennebarrie deleted the html-interpolation branch May 9, 2022 12:58
@etiennebarrie
Copy link
Member Author

It was also merged in v1.x as 6936cd7, and that was shipped as v1.10.1.

@shopify-shipit shopify-shipit bot temporarily deployed to rubygems September 26, 2022 13:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@promulo promulo promulo approved these changes

@larouxn larouxn larouxn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better HTML doesn't like the new refresh
3 participants
@etiennebarrie @promulo @larouxn