-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an extra line in rspec template to avoid rubocop errors #653
add an extra line in rspec template to avoid rubocop errors #653
Conversation
Hey @aditya-cherukuri , thanks for the contribution! You'll just need to sign the CLA before we can merge this. |
Thank you! Good idea. Can you do it for all the templates? |
Yup, signed one already! |
It seems to expect you to sign CLA as @aditya-cherukuri |
yeah it gave me an error when I tried to do it again. Let's see if the check passes on this run. |
@nvasilevski @adrianna-chang-shopify Is the CLA status stuck? It's been quite a while since I pushed the new commit and having signed the CLA |
Hey @aditya-cherukuri, I'm sorry for that trouble 🙇 Would you mind doing |
…ya-cherukuri/maintenance_tasks into rspec-template-file-rubocop
Looks like that worked but there are too many commits now. Hopefully you can squash the commits when you merge the pull request or let me know I'll try to squash and force push. |
squashed using github UI 👍 Thank you for your contribution! |
What are you trying to accomplish?
When using the generator to create a new maintenance task and an associated spec I get a rubocop warning about having to add a new line "RuboCop: Add an empty line after magic comments. [Layout/EmptyLineAfterMagicComment]"