Add resume run action to RunsController #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennebarrie
approved these changes
Jul 7, 2022
promulo
added a commit
that referenced
this pull request
Jul 18, 2022
lawrencewong
pushed a commit
to lawrencewong/maintenance_tasks
that referenced
this pull request
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
resumeroute and controller action that takes an individualRuninto account, in a similar fashion aspauseandcancel.Even though it seems redundant, this is ground work for a larger initiative, which is to allow tasks to have multiple active runs at a given time. I've decided to extract this particular bit in a separate PR since it is self-contained.
Current tests already cover the resume functionality, and that's why I haven't added any new tests.