README fixes #721
Merged
README fixes #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Active Storage has no notion of environment, only services and the default service.
adrianna-chang-shopify
approved these changes
Oct 26, 2022
| @@ -730,7 +730,7 @@ If no value is specified, it will default to 1 second. | |||
| #### Customizing which Active Storage service to use | |||
|
|
|||
| The Active Storage framework in Rails 6.1 and up supports multiple storage | |||
| services per environment. To specify which service to use, | |||
| services. To specify which service to use, | |||
There was a problem hiding this comment.
I wouldn't say AS has no notion of environment -- I think the intention here was that different environments should each be configured with a different service -- but I'm okay with removing this from the docs since it's not particularly helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to clear something following a question around Active Storage configuration, that's the first commit, the rest is some cleanup.