-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render a dropdown list when an inclusion validator is used #925
Conversation
hey @shalvah, thanks for the PR! Could you have a look on the CI failures? I think this feature makes sense and I don't have concerns with it. It uses mostly public APIs apart from |
FYI, tests are currently failing because of a ChromeDriver change which broke Capybara (teamcapybara/capybara#2725). They've fixed it, but not released yet, so I guess we have to wait a bit. This affects other PRs in this repo too. |
The Selenium issues were resolved in #936. |
Nice, thank you! Updated the branch, should pass now. |
Thanks @shalvah ! CI is green, but may I ask you to add a test for the feature? And this will be good to be merged |
Test added ✅ . Also, could someone please take a look at #924 ? I know it's a more involved design change, but it would be really helpful for many use cases, as explained in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
(there is one failing CI job which is related to Rails edge not supporting ruby 3 anymore, but unrelated to the PR)
Thanks! |
This allows you to write:
And get:
instead of:
Reduces the chance of making mistakes, saves work, serves as documentation for unfamiliar users (tells them what options are available).