Skip to content

Commit

Permalink
Merge pull request #379 from Shopify/revert-371-cw/update-stale-viola…
Browse files Browse the repository at this point in the history
…tions-error-message

Revert "Update stale violations error message to use bin/packwerk command"
  • Loading branch information
rafaelfranca authored Nov 8, 2023
2 parents 03bcb33 + 7e3911a commit 76a0959
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lib/packwerk/formatters/default_offenses_formatter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def show_offenses(offenses)
sig { override.params(offense_collection: OffenseCollection, file_set: T::Set[String]).returns(String) }
def show_stale_violations(offense_collection, file_set)
if offense_collection.stale_violations?(file_set)
"There were stale violations found, please run `bin/packwerk update-todo`"
"There were stale violations found, please run `packwerk update-todo`"
else
"No stale violations detected"
end
Expand Down
8 changes: 4 additions & 4 deletions test/unit/packwerk/commands/check_command_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class CheckCommandTest < Minitest::Test
📦 Finished in \\d+\\.\\d+ seconds
No offenses detected
There were stale violations found, please run `bin/packwerk update-todo`
There were stale violations found, please run `packwerk update-todo`
EOS
assert_match(/#{expected_output}/, out.string)

Expand Down Expand Up @@ -238,7 +238,7 @@ class CheckCommandTest < Minitest::Test
📦 Finished in \\d+\\.\\d+ seconds
No offenses detected
There were stale violations found, please run `bin/packwerk update-todo`
There were stale violations found, please run `packwerk update-todo`
EOS
assert_match(/#{expected_output}/, out.string)

Expand Down Expand Up @@ -351,7 +351,7 @@ class CheckCommandTest < Minitest::Test
1 offense detected
There were stale violations found, please run `bin/packwerk update-todo`
There were stale violations found, please run `packwerk update-todo`
EOS
assert_match(/#{expected_output}/, out.string)

Expand Down Expand Up @@ -390,7 +390,7 @@ class CheckCommandTest < Minitest::Test
📦 Finished in \\d+\\.\\d+ seconds
No offenses detected
There were stale violations found, please run `bin/packwerk update-todo`
There were stale violations found, please run `packwerk update-todo`
EOS
assert_match(/#{expected_output}/, out.string)

Expand Down

0 comments on commit 76a0959

Please sign in to comment.