Skip to content

Commit

Permalink
Remove ruby version references in ci checks
Browse files Browse the repository at this point in the history
Github Actions defaults to .ruby-version

Also reintroducing the bundler cache, and ignore vendored gems from typecheck
as it was causing typecheck to fail instead of bundle installing manually
  • Loading branch information
jenshenny committed Jun 20, 2024
1 parent 3260a04 commit c214792
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.1"
bundler-cache: true
- name: Run style checks
run: bin/rubocop
Expand All @@ -75,12 +74,9 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.1"
# bundler-cache: true
bundler-cache: true
- name: Run static type checks
run: |
bundle install --jobs 4 --retry 3
bin/srb tc
run: bin/srb tc
buildall:
if: ${{ always() }}
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions sorbet/config
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
--dir
.
--enable-experimental-requires-ancestor
--ignore=/vendor/bundle

0 comments on commit c214792

Please sign in to comment.