Silence sorbet warning when booting with spring #328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Silence warning when booting with Sorbet.
Before:
After:
What approach did you choose and why?
use
defined?(Spring)
When booting the Rails app with Spring and the app uses Sorbet, Sorbet cannot be disabled because the app has likely already invoked a typed method.
What should reviewers focus on?
For now, this silences the error when disabling sorbet while using a spring booted server. It would be nice if we could look at disabling at at the right time in a safer way, but I have no idea how to do that yet reading spring. Maybe we need to boot our own version of a test mode spring server with typechecking disabled. See #327
Type of Change
Additional Release Notes
Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.
If no additional notes are necessary, delete this section or leave it unchanged.
Checklist