Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize Ruby Version to .ruby-version #399

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
matrix:
gemfile:
- Gemfile
- gemfiles/Gemfile-rails-6-0
- gemfiles/Gemfile-rails-6-1
ruby:
- "2.7"
Expand Down Expand Up @@ -64,7 +63,6 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.1"
bundler-cache: true
- name: Run style checks
run: bin/rubocop
Expand All @@ -75,9 +73,8 @@ jobs:
- uses: actions/checkout@v2
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.1"
# bundler-cache: true
# with:
# bundler-cache: true
- name: Run static type checks
run: |
bundle install --jobs 4 --retry 3
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require:
- rubocop-sorbet

AllCops:
TargetRubyVersion: 2.7
TargetRubyVersion: 2.7 # TODO: Remove once Rubocop is updated to >= 1.61
NewCops: disable
UseCache: true
SuggestExtensions: false
Expand Down
1 change: 1 addition & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ GEM

PLATFORMS
arm64-darwin-21
arm64-darwin-22
x86_64-darwin
x86_64-darwin-20
x86_64-linux
Expand Down
2 changes: 1 addition & 1 deletion dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: packwerk
type: ruby

up:
- ruby: 3.2.2
- ruby
- bundler

commands:
Expand Down
22 changes: 0 additions & 22 deletions gemfiles/Gemfile-rails-6-0

This file was deleted.

Loading