Storybook addon-a11y fails with a11y errors about aria-label

[stufreen]

Issue summary

New versions of axe-core (4.2 and later) will treat it as a violation if you have aria-label attribute on generic elements like span. See the Axe changelog and this PR. Polaris does this on the Icon component and maybe others as well.

This is significant because recent versions of @storybook/addon-a11y use axe-core 4.2.0. See @kaelig PR here.

Projects using Polaris and addon-a11y in their CI pipeline will either have to disable this rule or cannot upgrade Storybook.

Expected behavior

The a11y rule linked in the axe-core PR seems valid. Screen readers apparently won't read aria-label for generic elements, so they should be removed.

Actual behavior

Polaris includes aria-label for many generic elements.

Steps to reproduce the problem

1. Install @storybook/addon-a11y version 6.3.7 and Polaris on the same project
2. Run storybook
3. Open accessibility tab for a story that includes one of the affected components (e.g. Icon with accessibilityLabel prop)
4. A violation will appear relating to the aria-label attribute

Specifications

• Are you using the React components? (Y/N): Y
• Polaris version number: 6.5.0
• Browser: NA
• Device: NA
• Operating System: NA

[ghost]

👋 Thanks for opening your first issue. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

[BPScott]

We updated our own storybook, spotted this issue and fixed this a few days ago in #4414. It'll go out as part of the next release.