Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-a11y/Storyshots: Upgrade axe-core to 4.2.0 and related dependencies #14749

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

kaelig
Copy link
Contributor

@kaelig kaelig commented Apr 29, 2021

What I did

Axe-core v4.2.0 was just released (release notes), let's update to this new version across the board.

[Possible breaking change] (?) This may result in failing builds for projects that automate a11y tests in CI, as new accessibility violations from rules introduced in 4.2.0 may be reported.

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes (as in: tests may break)
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

@kaelig kaelig changed the title [addon-a11y and storyshots-puppeteer] Upgrade axe-core and related dependencies [addon-a11y and storyshots-puppeteer] Upgrade axe-core to 4.2.0 and related dependencies Apr 29, 2021
@nx-cloud
Copy link

nx-cloud bot commented Apr 29, 2021

Nx Cloud Report

CI ran the following commands for commit fb4f441. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman changed the title [addon-a11y and storyshots-puppeteer] Upgrade axe-core to 4.2.0 and related dependencies Addon-a11y/Storyshots: Upgrade axe-core to 4.2.0 and related dependencies Apr 29, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaelig 🙏

This is in the semver grey zone, and I'm ok with the change. I'll put it on alpha and roll back if anybody complains too loudly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants