This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
🔥 remove the mentioned of locale from quilt_rails and link the exampl… #1300
+14
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michenly
commented
Feb 27, 2020
michenly
force-pushed
the
update-quilt-rails-docs
branch
from
6618755
to
391ee98
Compare
kvendrik
approved these changes
Feb 28, 2020
gems/quilt_rails/README.md
Outdated
| @@ -390,7 +390,7 @@ With SSR enabled React apps, state must be serialized on the server and deserial | |||
|
|
|||
| #### Customizing the node server | |||
|
|
|||
| By default, sewing-kit bundles in `@shopify/react-server-webpack-plugin` for `quilt_rails` applications to get apps up and running fast without needing to manually write any node server code. If what it provides is not sufficient, a custom server can be defined by adding a `server.js` or `server.ts` file to the app folder. | |||
| By default, sewing-kit bundles in [`@shopify/react-server-webpack-plugin`](../../packages/react-server-webpack-plugin/README.md) for `quilt_rails` applications to get apps up and running fast without needing to manually write any node server code. If what it provides is not sufficient, a completely custom server can be defined by adding a `server.js` or `server.ts` file to the app folder. | |||
gems/quilt_rails/README.md
Outdated
|
|
||
| export default app; | ||
| ``` | ||
| The simplest way to build a custom server that will work with this library is to use the APIs provided by [`@shopify/react-server`](../../packages/react-server/README.md). |
There was a problem hiding this comment.
Suggested change
| The simplest way to build a custom server that will work with this library is to use the APIs provided by [`@shopify/react-server`](../../packages/react-server/README.md). | |
| The simplest way to customize the server is to create a `server.tsx` file in your `app/ui` folder. This server file should export a [`@shopify/react-server`](../../packages/react-server/README.md) `createServer` call. |
…e to react-server directly
michenly
force-pushed
the
update-quilt-rails-docs
branch
from
391ee98
to
c9a67da
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e to react-server directly