Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

[koa-shopify-auth] add prefix support post pull [#1413] #1428

Closed
wants to merge 2,283 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2283 commits
Select commit Hold shift + click to select a range
977535b
Merge branch 'master' into mention-react-form
alanthai Feb 20, 2020
ecaca5c
Merge branch 'master' into react-form-isChangeEvent-fix-null-case
alanthai Feb 20, 2020
511522b
Merge pull request #1284 from Shopify/mention-react-form
alanthai Feb 24, 2020
738cf02
Merge branch 'master' into react-form-isChangeEvent-fix-null-case
alanthai Feb 24, 2020
bad1056
Update the jest Matches types to support the new type
alexandcote Feb 22, 2020
166eba8
Merge pull request #1295 from Shopify/fix_jest_types
michenly Feb 24, 2020
2ff2243
Allow passing a `fetchPolicy` to `useBackgroundQuery`
Feb 21, 2020
fdc913b
Merge pull request #1293 from Shopify/useBackgroundQuery
tleunen Feb 25, 2020
87d20b4
Use @shopify/dates formatDate function and memoize Intl.NumberFormat
Feb 18, 2020
c99efed
Merge pull request #1287 from Shopify/reacti18n-use-formatDate-from-d…
helloneele Feb 25, 2020
e95a835
Merge branch 'master' into react-form-isChangeEvent-fix-null-case
alanthai Feb 25, 2020
1e7e399
Merge pull request #1290 from Shopify/react-form-isChangeEvent-fix-nu…
alanthai Feb 25, 2020
8b0f462
Allow hour12 true to be respected by formatDate
carysmills Feb 26, 2020
db55d0a
Merge pull request #1299 from Shopify/dates-formatting-12-hr
carysmills Feb 27, 2020
03680ec
Publish
michenly Feb 27, 2020
86abfe8
Self service for beta releases
ismail-syed Feb 12, 2020
52d95d3
PR fixes
ismail-syed Feb 26, 2020
074e210
Use dev tag to release to prevent beta polution
ismail-syed Feb 26, 2020
d6dbeb0
Typo
ismail-syed Feb 28, 2020
5d3b670
Merge pull request #1278 from Shopify/self-server-beta-releases
ismail-syed Feb 28, 2020
f7192a2
🔥 remove the mentioned of locale from quilt_rails and link the exampl…
michenly Feb 27, 2020
a90e00e
Merge pull request #1300 from Shopify/update-quilt-rails-docs
michenly Feb 28, 2020
c0acc0b
Replace route propagator with moved notice (#1294)
iainmcampbell Mar 2, 2020
f8c861e
Add support for custom dirty state comparator
michaelmelanson Feb 20, 2020
99de99a
Review comments
michaelmelanson Mar 3, 2020
de1a4ba
Merge pull request #1296 from Shopify/michaelmelanson/deep-dirty-chec…
michaelmelanson Mar 3, 2020
dd4b597
Deprecate @shopify/react-shopify-app-route-propagator
alexandcote Mar 4, 2020
ca5ecc4
Merge pull request #1304 from Shopify/deprecate_app_route_propagator
michenly Mar 4, 2020
1940c11
Publish
alexandcote Mar 4, 2020
a75f36c
useList list as arg
alanthai Mar 6, 2020
0e45fd8
shipit doesnt seem to support dev dist-tag
ismail-syed Mar 6, 2020
88a0c7f
Merge branch 'master' into fix_typ
Mar 9, 2020
c783142
Merge pull request #1311 from Shopify/fix-beta-release-steps
ismail-syed Mar 9, 2020
6350390
Merge branch 'master' into react-form-use-list-list-as-arg
alanthai Mar 9, 2020
13a8c55
Merge pull request #1309 from Shopify/react-form-use-list-list-as-arg
alanthai Mar 9, 2020
68d2115
remove need to whitelist locales in @shopify/address
TayKangSheng Mar 3, 2020
f39f184
add back fallback to en feature
TayKangSheng Mar 3, 2020
f9d5391
update LoadCountriesResponse LoadCountryResponse and ResponseError
TayKangSheng Mar 3, 2020
c9eb424
add mocks for unsupported locales
TayKangSheng Mar 3, 2020
a1faeb4
add CHANGELOG entry for @shopify/address, @shopify/address-consts and…
TayKangSheng Mar 6, 2020
be0fe45
update CHANGELOG for @shopify/address-consts to indicate breaking change
TayKangSheng Mar 9, 2020
87e6f7b
extract graphql error into a type
TayKangSheng Mar 9, 2020
ba40d93
Merge pull request #1301 from Shopify/expand_locale_support_for_shopi…
TayKangSheng Mar 10, 2020
6c91fcf
✖️remove react-effect-apollo
michenly Mar 10, 2020
d7f075b
Merge pull request #1315 from Shopify/deprecate-react-effect-apollo
michenly Mar 10, 2020
399b5b0
Publish
michenly Mar 10, 2020
07d8638
remove references to removed packages
vsumner Mar 10, 2020
e5fc9c4
update test
vsumner Mar 10, 2020
cec1a99
Merge pull request #1317 from Shopify/remove-refs
vsumner Mar 10, 2020
0489ca9
Upgrade koa and it's types to latest
vsumner Mar 10, 2020
1fb2ecc
Dedupe mime-types
vsumner Mar 10, 2020
42dea4a
de-dup @types/express
vsumner Mar 10, 2020
6c242e4
Fix for promise
vsumner Mar 10, 2020
7a99974
✨add package deprecation document, and update current quilt according…
michenly Mar 10, 2020
cb5ce43
Merge pull request #1318 from Shopify/deprecate-package
michenly Mar 10, 2020
b306878
[react-form] Actually use `dirtyStateComparator` from config.
michaelmelanson Mar 4, 2020
4da3b42
Merge pull request #1305 from Shopify/michaelmelanson/fix-dirty-state…
michaelmelanson Mar 11, 2020
607bc2e
Add useInterval utility hook
sambostock Jan 21, 2020
4028d44
Merge pull request #1241 from Shopify/use-interval
sambostock Mar 11, 2020
2d6c511
Merge pull request #1316 from Shopify/upgrade-koa
vsumner Mar 11, 2020
4940b7b
✨ add mentioned to `@shopify/polyfills/intl`
michenly Mar 10, 2020
0947d5b
Merge pull request #1319 from Shopify/add-mentioned
michenly Mar 11, 2020
80ee764
Add note about text
ismail-syed Mar 12, 2020
4436e3e
Merge pull request #1324 from Shopify/clearer-release-docs
ismail-syed Mar 12, 2020
f878349
Publish
Mar 12, 2020
0bf82d2
Deprecate @shopify/serialize
alexandcote Mar 12, 2020
275c9d6
Bump 'serialize-javascript@^3.0.0'
alexandcote Mar 6, 2020
fcf77f5
Limit the serialized data to be a JSON object
alexandcote Mar 12, 2020
30c123f
Update @shopify/react-google-analytics dependencies
alexandcote Mar 12, 2020
4ce8bb5
Update @shopify/react-server stale dependencies
alexandcote Mar 12, 2020
d44515a
Update @shopify/react-form-state stale dependencies
alexandcote Mar 12, 2020
3ec30a8
Merge pull request #1312 from Shopify/solve_security_vulnerability
alexandcote Mar 12, 2020
9cdeedd
[react-form] CHANGELOG section for 4.2.2 release
michaelmelanson Mar 12, 2020
923260b
✖️remove react-apollo and replace the usage with individual package. …
michenly Mar 11, 2020
cc910f5
Merge pull request #1321 from Shopify/replace-react-apollo
michenly Mar 13, 2020
f00c75a
Publish
michenly Mar 13, 2020
cc9518b
Fix every tsconfig references
alexandcote Mar 12, 2020
ab08fdf
Remove every unsed dependencies
alexandcote Mar 13, 2020
7958523
Merge branch 'master' into michaelmelanson/react-form-4.2.2-changelog
michaelmelanson Mar 16, 2020
faabb81
Merge pull request #1326 from Shopify/fix_tsconfig_references
alexandcote Mar 19, 2020
1cb1184
Merge branch 'master' into michaelmelanson/react-form-4.2.2-changelog
michaelmelanson Mar 20, 2020
3b460ea
Allow assetname from context (#1332)
Mar 23, 2020
7f212ca
Publish
Mar 23, 2020
7d4946a
Merge branch 'master' into michaelmelanson/react-form-4.2.2-changelog
michaelmelanson Mar 23, 2020
637a4b3
Merge pull request #1325 from Shopify/michaelmelanson/react-form-4.2.…
michaelmelanson Mar 23, 2020
bf11099
:sparkles: Add `hasEasternNameOrderFormatter` method
kartiki975 Mar 17, 2020
adc96a2
Merge pull request #1329 from Shopify/kartiki/has-custom-name-formatter
kartiki975 Mar 24, 2020
2bc8ddc
Publish
michenly Mar 24, 2020
b1e8119
✨ make csrf less of with quilt_rails and graphql when needed, and enh…
Mar 20, 2020
48df2bd
Merge pull request #1331 from Shopify/nicer-csrf
michenly Mar 24, 2020
11d84db
Publish
michenly Mar 24, 2020
3456912
Release quilt_rails v1.11.0
michenly Mar 24, 2020
46168f1
Release quilt_rails v1.11.1
michenly Mar 24, 2020
91ff0a7
♻️ Mostly just a refactor
michenly Mar 30, 2020
183c0be
Merge pull request #1343 from Shopify/carry-over-with-env-next
michenly Mar 30, 2020
b326b2a
Publish
michenly Mar 30, 2020
340c359
🧹 clean up CHANGELOG.md files and add checks to keep them that way (#…
Mar 31, 2020
2a3cfa5
[react-form] reduceFields utilities (#1307)
alanthai Apr 1, 2020
6f51f32
🗒️ reorganize README for ease of use (#1333)
Apr 1, 2020
ca6ced6
Publish
Apr 1, 2020
e7ff4d7
Use .ts instead of unneeded .tsx extension
sambostock Jan 21, 2020
66ae095
Refactor tests
sambostock Mar 4, 2020
c0d40ba
Improve hook
sambostock Mar 4, 2020
e8f385f
Merge pull request #1306 from Shopify/improve-use-timeout
sambostock Apr 1, 2020
308daa1
Add korean eastern name formatter (#1340)
slucaskim Apr 2, 2020
4e9387b
📝 Fix missing backtick
GoodForOneFare Apr 2, 2020
f738af4
[React Form] fix list validation on submit (#1335)
sylvhama Apr 2, 2020
4f79105
Publish
alexandcote Apr 2, 2020
a25795c
:🗒️ Retroactive decision log for @shopify/react-testing (#1348)
Apr 2, 2020
8e6ac6f
:broom: cleanup some wording
Apr 2, 2020
a7ba2f3
[React-i18n] Add defaultLocale option to babel plugin (#1225)
nimzco Apr 2, 2020
1c34876
adding 'form: auto' to formatCurrency
Apr 2, 2020
e50cff4
Merge pull request #1350 from Shopify/react-i18n/formatcurrency-auto
Apr 2, 2020
f4061fc
Publish
Apr 2, 2020
06b0581
[Bugfix] Fix getQueuingTime header extraction (#1352)
kelhusseiny Apr 3, 2020
bd48f2a
Publish
michenly Apr 3, 2020
4cc0022
[react-hook] Improve useOnValueChange hook to use useEffect (#1351)
alexandcote Apr 7, 2020
f2b2c20
[react-form] Fixed getValue on empty array (#1353)
alanthai Apr 7, 2020
c1c15e8
update changelogs
ismail-syed Apr 7, 2020
64ba7aa
Publish
ismail-syed Apr 7, 2020
896b3f5
Adds useDebouncedValue hook
arthurgouveia Apr 6, 2020
fb8cdab
Code Review: Changes method signature. Removes unnecessary useRef
arthurgouveia Apr 7, 2020
08f70a4
Merge pull request #1354 from Shopify/debounced-value
arthurgouveia Apr 8, 2020
a112e62
Removes "window" reference from "useDebouncedValue" hook
arthurgouveia Apr 8, 2020
7311926
Merge pull request #1360 from Shopify/remove-window-from-hook
arthurgouveia Apr 8, 2020
8108fd4
Publish
ismail-syed Apr 8, 2020
5e41531
Update changelog
ismail-syed Apr 8, 2020
41791ae
Avoid /u in regex for IE11 (#1363)
lemonmade Apr 9, 2020
d012b13
Publish
lemonmade Apr 9, 2020
faf4bd0
Use memoized number format for currency symbol
Mar 6, 2020
0e865d4
Merge pull request #1310 from Shopify/use-memoized-number-format
Apr 9, 2020
c03d95d
adding some additional exports
Apr 9, 2020
a22107d
Merge pull request #1365 from Shopify/react-i18n/additional-exports
Apr 9, 2020
8a2ae28
Publish
Apr 9, 2020
71cbd10
Update README.md (#1368)
Apr 13, 2020
5c569d8
Add value parameter to runValidation type definition
attila-berki Apr 9, 2020
b587bca
Merge pull request #1362 from Shopify/runValidation-value-parameter-t…
attila-berki Apr 13, 2020
4682945
Publish
alexandcote Apr 13, 2020
4056532
updating memoizedNumberFormatter to allow an undefined locale
Apr 9, 2020
0dfcb04
Merge pull request #1366 from Shopify/react-i18n/fix-memoizednumberfo…
Apr 13, 2020
38e80ff
exposing memoizedGetDateTimeFormat and adding getIanaTimeZone
Apr 9, 2020
60f5c0f
Merge pull request #1367 from Shopify/dates/expose-client-timezone
Apr 13, 2020
642427a
Publish
Apr 13, 2020
e8b060b
Upgrade node to 10.16.3
vsumner Apr 13, 2020
d4500d2
Replace 32 with 8239
vsumner Apr 13, 2020
5fd65e1
Merge pull request #1369 from Shopify/upgrade-node-10-16-3
vsumner Apr 14, 2020
cbc48e9
React hooks - add useMedia (#1364)
sylvhama Apr 14, 2020
a3248f9
upgrade typescript to 3.7
vsumner Feb 13, 2020
7595adf
Fix types
vsumner Apr 14, 2020
0738919
Merge pull request #1281 from Shopify/typescript-3-7
vsumner Apr 14, 2020
f749993
Publish
vsumner Apr 14, 2020
1111561
Merge pull request #1259 from Shopify/fix_typ
vsumner Apr 14, 2020
1acd788
Update jest to 25.3
vsumner Apr 14, 2020
6991c78
Update the changelog
vsumner Apr 14, 2020
54fb982
Merge pull request #1375 from Shopify/update-jest-25
vsumner Apr 15, 2020
2db2e91
Update Koa Proxy Api Versions
Apr 15, 2020
d00e9e2
Update changelog
Apr 15, 2020
cd8756c
Update yarn.lock
vsumner Apr 16, 2020
0b7383d
Merge pull request #1378 from Shopify/yarn-update
vsumner Apr 16, 2020
e5724b9
Update eslint and prettier
vsumner Apr 16, 2020
280e57f
Merge pull request #1381 from Shopify/lint-prettier-update-apr2020
vsumner Apr 17, 2020
3dfb777
Upgrade enzyme
vsumner Apr 16, 2020
ec01c50
Merge pull request #1380 from Shopify/enzyme-update-apr2020
vsumner Apr 17, 2020
a5224e8
Update graphql to 14.6.0 and remove types/graphql
vsumner Apr 16, 2020
a2b361f
Update changelog
vsumner Apr 17, 2020
33ea42e
Merge pull request #1379 from Shopify/upgrade-graphql-14.6
vsumner Apr 17, 2020
ac16f34
Update jest matcher types
jgodson Jan 19, 2020
1235dad
update matchers to match @types/jest
vsumner Apr 16, 2020
f1ccffc
Update Changelog
vsumner Apr 17, 2020
da4b530
Upgrade graphql-typed to 0.5.0
vsumner Apr 17, 2020
7d77a43
Merge pull request #1385 from Shopify/graphql-typed-0.5.0
vsumner Apr 17, 2020
cff046c
Merge branch 'master' into update-jest-matcher-types
jgodson Apr 17, 2020
b4ab7e9
Merge pull request #1239 from Shopify/update-jest-matcher-types
jgodson Apr 17, 2020
1e4821f
Upgrade apollo
vsumner Apr 17, 2020
ce19d78
Merge pull request #1386 from Shopify/upgrade-apollo-apr2020
vsumner Apr 17, 2020
6ce7859
Update readme for Fixing rejected CSRF tokens (#1388)
Apr 20, 2020
89bbf6b
Publish
vsumner Apr 20, 2020
5383b3b
Fix available permits in Semaphore
Apr 21, 2020
4a71261
Merge pull request #1394 from Shopify/fix-semaphore-allowed-permits
tleunen Apr 21, 2020
9d4f82c
Publish
vsumner Apr 21, 2020
699ac4b
Add support for useMediaEffect
Apr 22, 2020
26ac05c
Adding base package for mime-types
posth Apr 14, 2020
e7701b8
Merge pull request #1371 from Shopify/files_package
posth Apr 22, 2020
f156ebe
Merge branch 'master' into media-hook-uselayouteffect
tleunen Apr 22, 2020
80770fc
Merge pull request #1396 from Shopify/media-hook-uselayouteffect
tleunen Apr 22, 2020
28ff25f
Add `innerWidth` mock to jest-dom-mocks
theodoretan Apr 22, 2020
0449025
Merge pull request #1399 from Shopify/jest-dom-mocks-innerWidth
theodoretan Apr 23, 2020
b78f7b9
Add future date considerations to the humanize functionality
jaxee Apr 20, 2020
57bac48
Adding a test for today in the future
jaxee Apr 22, 2020
f6a28f3
Merge pull request #1391 from Shopify/date-humanize-future-dates
jaxee Apr 23, 2020
72e55c6
added allErrors property to Field
sjreive Apr 17, 2020
71642a1
Merge branch 'master' into useField-validation-returns-all-errors
sjreive Apr 23, 2020
4eb3f4c
Merge pull request #1383 from Shopify/useField-validation-returns-all…
sjreive Apr 23, 2020
da701db
allErrors will return an empty array if there are no errors
sjreive Apr 23, 2020
30eeb0f
Merge pull request #1403 from Shopify/useField-allErrors-emptyArray
sjreive Apr 23, 2020
c2c0b90
Publish
alexandcote Apr 23, 2020
1d9c7cc
Adding extra common mime-types
posth Apr 14, 2020
e893483
Merge pull request #1372 from Shopify/adding_common_mime_types
posth Apr 24, 2020
4af6e15
Review changes
Apr 27, 2020
c135a69
Hooks argument type fixes (#1404)
CameronGorrie Apr 27, 2020
2dd0c99
Merge branch 'master' into update_graphql_proxy_api_versions
Apr 27, 2020
590fc86
Simple typo correction in the readme.md file (#1393)
adriancorcoran Apr 29, 2020
20012c7
Typo Correction (#1392)
adriancorcoran Apr 29, 2020
3bf0824
Update quilt_rails README Manual installation instructions
janiceblundell Apr 30, 2020
f08a9f4
Merge pull request #1410 from Shopify/quilt-rails-quick-start-docs
janiceblundell Apr 30, 2020
f8919e1
Add missing export for useMediaLayout + readme (#1408)
tleunen Apr 30, 2020
46d464c
Merge branch 'master' into update_graphql_proxy_api_versions
May 1, 2020
ccb48af
Publish
ismail-syed May 1, 2020
e78ee27
Update changelogs
ismail-syed May 1, 2020
dd2ff51
Fixing Safari 13.1 cookie loop
ragalie Apr 29, 2020
c8b1a54
Merge branch 'master' into update_graphql_proxy_api_versions
May 1, 2020
45fb4af
Merge pull request #1377 from Shopify/update_graphql_proxy_api_versions
May 1, 2020
7e47585
Merge pull request #1413 from Shopify/koa-request-storage-access
ismail-syed May 1, 2020
a1c00a9
Update changelogs
ismail-syed May 1, 2020
8f75405
Update @shopify/koa-shopify-graphql-proxy changelog as a breaking change
ismail-syed May 1, 2020
664cb20
Publish
ismail-syed May 1, 2020
66c8ba9
Use X-Quilt-Data header for rails to react-server communication
ismail-syed Apr 30, 2020
e6fc009
PR fixes
ismail-syed May 4, 2020
4316ba8
Merge pull request #1411 from Shopify/quilt_rails-data-support
ismail-syed May 4, 2020
596b658
Update changelog
ismail-syed May 4, 2020
d8128c2
Publish
ismail-syed May 4, 2020
5ee90bf
✨ magic-entries-webpack-plugin (#1412)
May 5, 2020
85d8c17
Publish
May 5, 2020
fb9b233
Publish @shopify/[email protected]
May 5, 2020
f833868
Release quilt_rails v1.12.0
ismail-syed May 7, 2020
9c48661
🔥 delete defunct providers API that was undocumented and not used any…
May 7, 2020
89b04ae
[react-graphql] Add fetchMore param to useQuery hook result documenta…
attila-berki May 7, 2020
2324767
🔥 weird warning (#1424)
May 7, 2020
810bfb0
Docs typo fix: "to here about" => "to hear about"
GoodForOneFare May 8, 2020
697a0bf
:fire: outdated API
May 8, 2020
fc9d3b0
Comment an empty unreleased section in the changelog (#1425)
alexandcote May 8, 2020
da9fa2e
[koa-shopify-auth] fixes prefix support for pull #1413
kavika-1 May 10, 2020
bd859fa
✨💥 pass data, url to app component by default in react-server-webpac…
May 11, 2020
c6dc4ef
Update readme to link to web-foundation handbook
js-aff Apr 21, 2020
a7203f7
Merge pull request #1395 from Shopify/handbook-link-fix
js-aff May 12, 2020
cddc202
Publish
May 12, 2020
a85f2d7
Merge branch 'master' into koa-auth-add-prefix-to-redirect
kavika-1 May 13, 2020
7ce21af
undo change to appTargetUrl
May 13, 2020
66f4292
✨💥 pass data, url to app component by default in react-server-webpac…
May 11, 2020
1ed1d47
Update readme to link to web-foundation handbook
js-aff Apr 21, 2020
66081b9
Publish
May 12, 2020
07c2e63
undo change to appTargetUrl
May 13, 2020
cd12376
Merge branch 'koa-auth-add-prefix-to-redirect' of https://github.com/…
kavika-1 May 13, 2020
835b622
[enzyme-utilities] trigger now always return the value
alexandcote May 13, 2020
c1fa015
Remove duplicated entry in the changelog
alexandcote May 13, 2020
78e1de0
Merge pull request #1434 from Shopify/fix_enzyme_trigger
alexandcote May 13, 2020
ed7f025
Publish
alexandcote May 13, 2020
2b72431
Update README.md
May 13, 2020
6409012
Update README.md
May 13, 2020
8a08ef6
Merge branch 'master' into koa-auth-add-prefix-to-redirect
kavika-1 May 13, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
11 changes: 0 additions & 11 deletions .circleci/config.yml

This file was deleted.

3 changes: 3 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
node_modules
coverage
**/node_modules/*
**/packages/*.js
*.d.ts
**/templates/*
**/dummy/**
6 changes: 0 additions & 6 deletions .eslintrc

This file was deleted.

57 changes: 57 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
module.exports = {
extends: [
'plugin:@shopify/typescript',
'plugin:@shopify/typescript-type-checking',
'plugin:@shopify/react',
'plugin:@shopify/jest',
'plugin:@shopify/prettier',
],
parserOptions: {
project: [
'packages/tsconfig.json',
'packages/tsconfig_base.json',
'test/tsconfig.eslint.json',
],
},
rules: {
'jest/valid-expect-in-promise': 'off',
'import/extensions': 'off',
'jsx-a11y/control-has-associated-label': 'off',
'node/no-extraneous-require': 'off',
'import/no-cycle': 'off',
'jest/require-tothrow-message': 'off',
'callback-return': 'off',
'func-style': 'off',
'react/display-name': 'off',
'@shopify/restrict-full-import': ['error', 'lodash'],
'@shopify/jsx-no-hardcoded-content': 'off',
// reports false positives with React's useRef hook
'require-atomic-updates': 'off',
'@typescript-eslint/no-unnecessary-type-arguments': 'off',
'@typescript-eslint/no-unnecessary-condition': 'off',
'@typescript-eslint/prefer-readonly': 'off',
'@typescript-eslint/ban-types': 'off',
'@typescript-eslint/unbound-method': 'off',
'@typescript-eslint/no-misused-promises': 'off',
'@typescript-eslint/await-thenable': 'off',
'@typescript-eslint/no-misused-promises': 'off',
'import/no-extraneous-dependencies': 'error',
},
overrides: [
{
files: [
'**/test/**/*.ts',
'**/test/**/*.tsx',
'**/tests/**/*.ts',
'**/tests/**/*.tsx',
],
rules: {
// We disable `import/no-extraneous-dependencies` for test files because it
// would force releases of `@shopify/react-testing` (and similar devDependencies)
// to cause unnecessary package bumps in every package that consumes them.
// Test files with extraneous dependencies won't cause runtime errors in production.
'import/no-extraneous-dependencies': 'off',
},
},
],
};
46 changes: 46 additions & 0 deletions .github/CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# Contributor Covenant Code of Conduct

## Our Pledge

In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.

## Our Standards

Examples of behavior that contributes to creating a positive environment include:

- Using welcoming and inclusive language
- Being respectful of differing viewpoints and experiences
- Gracefully accepting constructive criticism
- Focusing on what is best for the community
- Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

- The use of sexualized language or imagery and unwelcome sexual attention or advances
- Trolling, insulting/derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others' private information, such as a physical or electronic address, without explicit permission
- Other conduct which could reasonably be considered inappropriate in a professional setting

## Our Responsibilities

Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.

Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.

## Scope

This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at [email protected]. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.

Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]

[homepage]: http://contributor-covenant.org
[version]: http://contributor-covenant.org/version/1/4/
109 changes: 109 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
# Quilt: a contributor's guide

This guide is tailored to Shopifolk, although we welcome contributions from [the broader development community](#external-contributors) as well.

## [Code of conduct](./CODE_OF_CONDUCT.md).

Shopify has adopted a Code of Conduct that we expect Quilt contributors to adhere to. Please read the [full text](./CODE_OF_CONDUCT.md) so that you can understand what actions will and will not be tolerated.

## Ways to contribute

There are many ways to contribute to Quilt, some of which are:

- Filing [bug reports](https://github.com/Shopify/quilt/issues/new?template=BUG_REPORT.md)
- Requesting new features or packages via [an issue](https://github.com/Shopify/quilt/issues/new/choose)
- Bringing up areas for enhancement
- Hacking away on an issue from our [backlog](https://github.com/Shopify/quilt/issues)
- Improving tests or documentation

Want to contribute, but not sure how? Find us on Slack in `#web-foundation-tech`.

## Development

### Getting Started

```bash
dev clone quilt
dev up
```

[what is dev?](#what-is-dev)

### Getting productive

We are adding documentation as we go in the [Web Foundation repo](https://github.com/Shopify/web-foundation). There you will find our [decision records](https://github.com/Shopify/web-foundation/tree/master/Decision%20records), [principles](https://github.com/Shopify/web-foundation/tree/master/Principles), [best practices](https://github.com/Shopify/web-foundation/tree/master/Best%20practices) and [styleguides](https://github.com/Shopify/web-foundation/tree/master/Styleguides) for writing and [testing](https://github.com/Shopify/web-foundation/blob/master/Best%20practices/Testing.md) different kinds of components.

The [documentation](../documentation) directory in this repo covers the more granular technical aspects of this project. Of particular note for new folks are the following:

- [Guides](../documentation/guides): a set of guides to help you get started developing with `quilt`. Of particular note for developers just starting on the project is our guide to [creating a new package](../documentation/guides/creating-a-new-package.md).
- [FAQ](../documentation/FAQ.md): common questions about the project in general, as well as some of the technical pieces within.
- [Resources](../documentation/resources.md): good resources for understanding this project’s tech stack.
- [Getting started](../documentation/getting-started.md): some tools we recommend for getting the most out of this project.

## Testing your changes in a local project

To try out your changes in another locally cloned project, you can use `yarn tophat <package-name-without-@shopify-prefix> <relative-path-to-project>`. Using this command rather than `yarn link` will set up a watcher let you make changes without needing to rerun any commands.

Example: To test my changes to `@shopify/react-form-state` in my local project named `cool-proj`, I would run `yarn tophat react-form-state ../path/to/cool-proj`.

Notes: If the package you are testing has dependencies inside Quilt itself, you will need to run `dev build` first. If you are using a build system in the consumer of the package, you may need to clear your build folder.

More usage instructions on the `tophat` command can be [found here](https://github.com/Shopify/webgen/blob/master/docs/TOPHAT.md).

### Emoji commits

We have found that prefacing a commit message or PR title with an emoji can be a great way to improve the developer experience when browsing the repo code. Additionally, it is a terse way to convey information. Many of our contributors have found the guide at https://gitmoji.carloscuesta.me/ to be helpful in preserving this dynamic.

### Documentation

If your change affects the public API of any packages within Quilt (i.e. adding or
changing arguments to a function, adding a new function, changing the
return value, etc), please ensure the documentation is also updated to
reflect this. Documentation is in the `README.md` files of each package. If further documentation is needed please communicate via Github Issues.

### Testing

The packages in Quilt are used in mission-critical production scenarios. As such, we try not to merge any untested code. The coverage doesn't strictly need to be 100% across the board, but testing should remain a primary concern.

To run the full test suite, simply run `dev test`. In order for tests to run properly, you may need to first run `dev build`

### TODO Comments

TODO comments may seem like a great placeholder for work in progress. We prefer to handle this in a different way, using a combination of feature branches and github issues.

#### Follow-up Github issues

If your changes are complete in functionality, but you're not quite happy with auxillary things like documentation or testing, then feel free to make a github issue to track the work that needs to be done. These issues should be linked in the PRs that need a bit more work. This will allow context to be drawn from the code in a more trackable way than a TODO comment. Also, it allows the PR reviewers to see that the documentation or testing is purposefully incomplete and that an appropriate issue exists to track the follow-up work.

#### Feature branches

Another option, if you'd like to break work down into reviewable chunks, is to use a feature branch. This would be an initially empty branch that contains the entirety of your feature. Additional units of work can be distributed across several PRs into the feature branch, merged independently, and then the feature branch can be merged as a complete unit into the master branch, when it's ready.

## Releasing

The release process currently involves some manual steps to complete. Please ping Web Foundations ATC in the `#web-foundation-tech` Slack channel when you're ready to merge a new PR into `master`, and we will orchestrate a new release. The repo owner can follow [this guide](../documentation/guides/release-and-deploy.md) to create a release.

**Note** Version numbers in `package.json` files should never be altered manually. This will be done via scripts as part of the release process.

## External Contributors

### Getting started

To start working on the codebase, first fork the repo, then clone it:

```
git clone [email protected]:your-username/quilt.git
```

_Note: replace "your-username" with your Github handle_

Install the project's dependencies (make sure you first have [yarn](https://yarnpkg.com/) installed):

```
yarn
yarn lerna bootstrap
```

### What is dev?

`dev` is a tool to standardize a small set of common tasks across all projects at Shopify. If you're wondering how to execute the `dev <cmd>` commands as an external contributor, you can see where they are defined in this project's [`dev.yml`](../dev.yml) file, which is pretty self-explanatory.
35 changes: 35 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG_REPORT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
name: '🐛 Bug Report'
about: Something isn't working
---

## Overview

...

## Consuming repo

> What repo were you working in when this issue occurred?

...

## Labels

- [ ] Add the `Type: Bug` label to this issue.

### Area

- [ ] Add any relevant `Area: <area>` labels to this issue

### Scope

- Is this issue related to a specific package?

- [ ] Tag it with the `Package: <package_name>` label.

---

## Checklist

- [ ] Please delete the labels section before submitting your issue
- [ ] I have described this issue in a way that is actionable (if possible)
35 changes: 35 additions & 0 deletions .github/ISSUE_TEMPLATE/ENHANCEMENT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
name: '📈 Enhancement'
about: Enhancement to our codebase that isn't a adding or changing a feature
---

## Overview

...

## Motivation

> What inspired this enhancement? What makes you think this should be in `quilt`?

...

## Labels

- [ ] Add the `Type: Enhancement` label to this issue.

### Area

- [ ] Add any relevant `Area: <area>` labels to this issue

### Scope

- Is this issue related to a specific package?

- [ ] Tag it with the `Package: <package_name>` label.

---

## Checklist

- [ ] Please delete the labels section before submitting your issue
- [ ] I have described this issue in a way that is actionable (if possible)
44 changes: 44 additions & 0 deletions .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
---
name: '🙌 Feature Request'
about: Suggest a new feature, or changes to an existing one
---

## Overview

...

## Type

- [ ] New feature
- [ ] Changes to existing features

## Motivation

> What inspired this feature request? What problems were you facing,
> or what else makes you think this should be in `quilt`?

...

## Labels

- [ ] Add the `Type: Feature Request` label to this issue.

### Area

- [ ] Add any relevant `Area: <area>` labels to this issue

### Scope

- Is this issue related to a specific package?

- [ ] Tag it with the `Package: <package_name>` label.

- Is it related to a new package?
- [ ] Tag it with the `New package` Label

---

## Checklist

- [ ] Please delete the labels section before submitting your issue
- [ ] I have described this issue in a way that is actionable (if possible)
25 changes: 25 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
## Description

Fixes (issue #)

<!--
Please include a summary of what you want to achieve in this pull request. Remember to indicate the affected package(s).
-->

## Type of change

<!--
If this pull request changes multiple packages, please indicate the type of change for each package.

If this is a new package, you may disregard this section.

Please delete options that are not relevant.
-->

- [ ] <!--Package Name--> Patch: Bug/ Documentation fix (non-breaking change which fixes an issue or adds documentation)
- [ ] <!--Package Name--> Minor: New feature (non-breaking change which adds functionality)
- [ ] <!--Package Name--> Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist

- [ ] I have added a changelog entry, prefixed by the type of change noted above
2 changes: 2 additions & 0 deletions .github/probots.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
enabled:
- cla
Loading