This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Pass caught server error to custom error component #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismail-syed
approved these changes
Nov 2, 2020
🎉 opened #1666 |
beckygowland
force-pushed
the
add-error-prop-to-custom-error
branch
4 times, most recently
from
84548d1
to
095d2a0
Compare
beckygowland
force-pushed
the
add-error-prop-to-custom-error
branch
from
99d1ae1
to
cb2533b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For custom error components, there's the server error that is supposed to be passed in as a prop that's currently undefined at the moment. This sets that value to the same error as what's caught and logged in the react server.
Type of change
Checklist