Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Move babel-plugins to dependencies in ast-utilities package #2072

Merged
merged 4 commits into from
Nov 13, 2021
Merged

Move babel-plugins to dependencies in ast-utilities package #2072

merged 4 commits into from
Nov 13, 2021

Conversation

cartogram
Copy link
Contributor

Description

This PR moves the babel plugin dependencies that are required in consuming projects to dependencies from devDependencies.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@cartogram cartogram requested a review from a team November 8, 2021 15:41
michenly
michenly approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@michenly michenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cartogram cartogram merged commit 0ecfa36 into main Nov 13, 2021
@cartogram cartogram deleted the @cartogram/ast-util-babel-plugin-deps branch November 13, 2021 10:21
@royleejr
Copy link
Contributor

@cartogram These changed have now been implemented in the new quilt packages release! @shopify/[email protected]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michenly michenly michenly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartogram @royleejr @michenly