This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Fix ci by locking node versions #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to yolomerge this to fix CI. I've updated the branch protection rules to require the new action names. |
This was referenced Feb 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2169
Node 14.19 and 16.14 contain updates to ICU, which affects how date formatting occurs. This change won't be backported onto the 12.x branch so we're in a fun state where latest 12.x gives different output to 14.x and 16.x, so for now lock to the last version in 14 and 16 before the ICU change. This gives us consistent behaviour across CI versions.
Once we drop support for node 12 (see #1970) we can consider using
14.xand16.xagain