This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
[graphql-typescript-definitions] Pass export-format cli option to Builder config #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calirvine
force-pushed
the
gql-ts-fix-cli
branch
from
051efe8
to
0d31875
Compare
calirvine
force-pushed
the
gql-ts-fix-cli
branch
from
0d31875
to
7aca49b
Compare
BPScott
approved these changes
Oct 27, 2023
|
Thanks for the spot! Approving, though as I'm no longer on the admin-web-platform team I no longer have permission to merge, you'll need somebody from that team to review and do the merge |
vsumner
approved these changes
Nov 6, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
export-formatcli option was added in 1c7dff6 (updated in #2289 and #2559) but never actually passed to theBuilderconfig. This means any projects that want to be typed for@apollo/clientor other libraries usingTypedDocumentNodecan not use the cli for generating their types. This PR adds the value to the CLI Builder.