Fix typescript error in i18n

[alex-page]

Updated NumberFormatOptionsStyleRegistry to align with latest version of typescript.

[BPScott]

Can we update this to as?: 'decimal' | 'currency' | 'percent'; so we fix the single problematic value, rather than widening the set of allowed values to include the es2020+ only 'unit'.

---

In TS 5.4 Intl.NumberFormatOptions['style'] was string | undefined.

TS 5.5 strictens that up to be a set of possible values (keyof Intl.NumberFormatOptionsStyleRegistry, the exact values of which change depending on which es version you're targeting - es5 supports decimal, percent and currency. es2020 adds unit).

No idea why /snapit is installing TS 5.5 when we request ts 5.4 in the package.json though.

---

I'm not sure if we want to count this as a patch or major.

We're removing a "valid" value which is technically a breaking change

But MDN suggests that number was never a valid value for the style option in the first place and doing Intl.NumberFormat('en', {style: 'number'}) is a runtime error. So we're making what was a runtime error now be highlighted at type-check time.

I'm tempted to try this as a patch change, do a snapit and see what breaks in web - if that's all good then do a patch.

[alex-page]

/snapit

[github-actions]

🫰✨ Thanks @alex-page! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/react-i18n": "0.0.0-snapshot-20240828004508",
"@shopify/react-i18n-universal-provider": "0.0.0-snapshot-20240828004508"

[alex-page]

Tophatted in /web in https://github.com/Shopify/web/pull/138778

There were some issues but they can be fixed forward in /web. Nothing critical from what I could see quickly.