This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
✨add defer prop for requestIdleCallback in react-import-remote
#561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
force-pushed
the
react-import-remote__ricb
branch
5 times, most recently
from
307d3ab
to
0edd490
Compare
react-shortcuts: Remove prop-types as a dependency PR #295 refactored react-shortcuts to use the modern context API which means prop-types is no longer needed Readme updates
cartogram
force-pushed
the
react-import-remote__ricb
branch
from
0edd490
to
7924d0f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/Shopify/web/issues/10479
This PR adds a
deferprop to the ImportRemote component that when set toIdleenum, loads the request withrequestIdelCallback.Some shared types have been moved to the basic
asyncpackage fromreact-async.TODO
requestIdleCallbacktojest-dom-mocks.