This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
🐛 fix auth issue with invalid accesstoken #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiedavis
force-pushed
the
koa-auth-bug
branch
from
05b7eb0
to
d57bc8c
Compare
tylerball
reviewed
Aug 13, 2019
marutypes
approved these changes
Aug 13, 2019
katiedavis
force-pushed
the
koa-auth-bug
branch
4 times, most recently
from
e567441
to
2360749
Compare
tylerball
approved these changes
Aug 13, 2019
katiedavis
force-pushed
the
koa-auth-bug
branch
from
2360749
to
fa07ebd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #727
Type of change
In the koa-shopify-auth package, users were having issues reinstalling their apps via the partner dashboard. This PR adds a call to the admin API (I tried to find the 'cheapest' call) to check the validity of the access token. This solve the issue of users not being able to reinstall the app on their stores.
I'm looking for feedback on this. If anyone knows a better way of checking if an access token is valid please let me know!
Checklist