Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signature for Money allocate_max_amounts #170

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix signature for Money allocate_max_amounts #170

merged 1 commit into from
Jul 31, 2023
+1 −1

Conversation

vinistock
Copy link
Member

Type of Change

  • Add RBI for a new gem
  • Modify RBI for an existing gem
  • Other:

Changes

The method actually accepts a Money object or a String in addition to Numeric.

@vinistock vinistock self-assigned this Jul 31, 2023
@vinistock vinistock requested a review from a team as a code owner July 31, 2023 14:36
egiurleo
egiurleo approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@egiurleo egiurleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@vinistock vinistock merged commit e162e36 into main Jul 31, 2023
4 checks passed
@vinistock vinistock deleted the vs/fix_money_sig branch July 31, 2023 14:56
@Morriar Morriar added the rbi Change related to RBI annotations label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egiurleo egiurleo egiurleo approved these changes

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan KaanOzkan is a code owner automatically assigned from Shopify/sorbet

Assignees

@vinistock vinistock

Labels
rbi Change related to RBI annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinistock @egiurleo @Morriar