Add sidekiq's perform_bulk method signature #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
vinistock
reviewed
Aug 3, 2023
| @@ -75,6 +75,9 @@ module Sidekiq::Job::ClassMethods | |||
|
|
|||
| sig { params(interval: T.untyped, args: T.untyped).returns(String) } | |||
| def perform_in(interval, *args); end | |||
|
|
|||
| sig { params(args: T.untyped, kwargs: T.untyped).returns(String) } | |||
| def perform_bulk(*args, **kwargs); end | |||
There was a problem hiding this comment.
The perform_bulk method in Job indeed accepts **kwargs, but under the hood it invokes Setter#perform_bulk, which only accepts batch_size.
Can you actually invoke this method with any keyword arguments that aren't batch_size? If not, maybe it's worth making it explicit.
There was a problem hiding this comment.
Good point! I've updated the PR. Forgive me, I'm still a bit of a sorbet noob, so there might be a better way of doing this. But this seems to do the trick.
There was a problem hiding this comment.
This is actually telling Sorbet to accept keyword arguments and that each one of them will be a { batch_size: Integer } shape. To get it to accept only batch_size, you need to do
sig { params(args: T.untyped, batch_size: Integer).returns(String) }
def perform_bulk(*args, batch_size: 1000); end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Changes