Video player fixes #2451
Merged
Video player fixes #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrEuler this is work in progress but this will allow us to have test cases for the video playing logic so we can have it more stable. |
|
@wcandillon you are rock! Let's not close the issue itself, so I can post more finding there and have it as the main thread for video issues. |
|
I think it would be good to make separate small issues as I am starting to
lose track of all the open issues
…On Wed 29 May 2024 at 10:27, OleksiiMaksymov ***@***.***> wrote:
@wcandillon <https://github.com/wcandillon> you are rock! Let's not close
the issue itself, so I can post more finding there and have it as the main
thread for video issues.
—
Reply to this email directly, view it on GitHub
<#2451 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKXVWQLULAJFPQ7GTDJXDZEWGPNAVCNFSM6AAAAABIONI6ZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZWHAZTONZRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@mrEuler I have more improvements I want to bring to this feature but in the meantime, here we have a basis to collaborate, we can add examples, test cases, and follow different issues on the topic |
|
🎉 This PR is included in version 1.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2442